Skip to content

fix(tui): settle stale replay work - #35693

Closed
fengjikui wants to merge 1 commit into
anomalyco:devfrom
fengjikui:replay-interrupted
Closed

fix(tui): settle stale replay work#35693
fengjikui wants to merge 1 commit into
anomalyco:devfrom
fengjikui:replay-interrupted

Conversation

@fengjikui

@fengjikui fengjikui commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Issue for this PR

Fixes #35642

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

When the TUI replays a session after reconnect/restart, it now checks session.status() before treating replayed active parts as still running. If the session is not busy/retrying, replay flushes stale active text/tool entries as interrupted instead of leaving spinners and the running footer active.

If the session is still busy/retrying, replay keeps those parts active so attaching to real background work still behaves normally.

This is scoped to the concrete TUI replay symptom. The broader durable core recovery contract remains tracked in #35467.

How did you verify your code works?

  • bun test src/cli/cmd/run/session-replay.test.ts
  • bun test src/cli/cmd/run
  • bun typecheck from packages/opencode
  • bunx prettier --check src/cli/cmd/run/session-data.ts src/cli/cmd/run/session-replay.ts src/cli/cmd/run/session-replay.test.ts src/cli/cmd/run/stream.transport.ts
  • bunx oxlint packages/opencode/src/cli/cmd/run/session-data.ts packages/opencode/src/cli/cmd/run/session-replay.ts packages/opencode/src/cli/cmd/run/session-replay.test.ts packages/opencode/src/cli/cmd/run/stream.transport.ts (0 errors; existing warnings in stream.transport.ts)
  • pre-push hook: bun turbo typecheck (30/30 tasks successful)

Screenshots / recordings

Not included; this is replay-state logic covered by the regression test.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions github-actions Bot added needs:compliance This means the issue will auto-close after 2 hours. needs:issue labels Jul 7, 2026
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions github-actions Bot removed the needs:compliance This means the issue will auto-close after 2 hours. label Jul 7, 2026
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

V2: interrupted work remains spinning after machine restart

1 participant